From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNp4t-0007nQ-NS for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:07:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNp4q-0001rS-Ub for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:07:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNp4q-0001qM-LL for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:07:44 -0400 Message-ID: <507C50E9.1050706@redhat.com> Date: Mon, 15 Oct 2012 12:07:37 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4FAC62D32ED0DC3A3CBDD8A0" Subject: Re: [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4FAC62D32ED0DC3A3CBDD8A0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/15/2012 11:29 AM, Alex Bligh wrote: > This patch allows qemu-img rebase to rebase an image to > have no backing file, as opposed to merely allowing it to > rebase to an existing backing file. You can already do that by rebasing to the empty string. And it is feasible (although unlikely) to have a file named '-', where your patch would make it impossible to use that file directly (although you could still use './-'). NACK. $ qemu-img info bar image: bar file format: qcow2 virtual size: 0 (0 bytes) disk size: 192K cluster_size: 65536 backing file: foo $ qemu-img rebase -u -b '' bar $ qemu-img info bar image: bar file format: qcow2 virtual size: 0 (0 bytes) disk size: 192K cluster_size: 65536 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4FAC62D32ED0DC3A3CBDD8A0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQfFDpAAoJEKeha0olJ0NqMfUIAK0M6ZsLjs4ni9IncoI3GUrI jROVjCcD8XvXJKI47rSmJ43jDZJtxPBUE5KR5Mecf9YuUpnzaWs47rYNhLclMvtN rw8yoZUgLxYcv0yptTzWE0+pwJCJGWWCssE04ovyfbm2cq7hiQvhk2zkfQ/ZbkFM bi3IQ0Y2p1JPF+JaN1SBUJns4gGkUCZTIO0P5GPGEXCNh6WurpY+KkJmNh5Ax3iA SXcr+8ewSGct9NrkEbshN5/8Dfkc7L/2+/mnunpKGSmVRLyn+Cq/RDdsIy2+ZT+8 M93XngE4EnvZwyOb7QPNfV6vH19z33t6WoW0kp7+JfWlwxip758ZEUdhOQI3bH8= =phBr -----END PGP SIGNATURE----- --------------enig4FAC62D32ED0DC3A3CBDD8A0--