From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TO0o2-0006QU-Jq
	for qemu-devel@nongnu.org; Tue, 16 Oct 2012 02:39:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TO0o1-0006XU-LY
	for qemu-devel@nongnu.org; Tue, 16 Oct 2012 02:39:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TO0o1-0006XQ-DG
	for qemu-devel@nongnu.org; Tue, 16 Oct 2012 02:39:09 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9G6d8Ix024125
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 16 Oct 2012 02:39:08 -0400
Message-ID: <507D0109.6070803@redhat.com>
Date: Tue, 16 Oct 2012 08:39:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com>
	<1348675011-8794-28-git-send-email-pbonzini@redhat.com>
	<507C48E9.4040901@redhat.com>
In-Reply-To: <507C48E9.4040901@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jcody@redhat.com, qemu-devel@nongnu.org

Il 15/10/2012 19:33, Kevin Wolf ha scritto:
>> > +
>> > +    flags = bs->open_flags | BDRV_O_RDWR;
> The two questions from last time are still open:
> 
> Jeff's patches are in now, so we can do a bdrv_reopen() to remove
> BDRV_O_RDWR again when completing the mirror job.

It's not a big change, so I'll add this to v3.

> The other thing was the throttling. It's not entirely clear to me what
> our conclusion was, but you suggested to remove it entirely from the
> mirror because I/O throttling on the target is equivalent.

Yes, that was because at the time you were suggesting to give the target
a name.  In the end that had too many problems, so I left that part out
for after Markus finishes his refactoring.

Paolo