From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO2Ac-0000pq-7Q for qemu-devel@nongnu.org; Tue, 16 Oct 2012 04:06:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TO2AZ-0003DB-8z for qemu-devel@nongnu.org; Tue, 16 Oct 2012 04:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO2AY-0003D1-WA for qemu-devel@nongnu.org; Tue, 16 Oct 2012 04:06:31 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9G86UiB008969 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Oct 2012 04:06:30 -0400 Message-ID: <507D1583.6030402@redhat.com> Date: Tue, 16 Oct 2012 10:06:27 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1350334682-27158-1-git-send-email-jcody@redhat.com> In-Reply-To: <1350334682-27158-1-git-send-email-jcody@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Am 15.10.2012 22:58, schrieb Jeff Cody: > In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation > from __negotiate_capabilities(), which breaks _accept(). This causes > failures in qemu-io python based tests (i.e. tests 030 and 040). > > This patch creates the sockfile in __accept() as well. > > Signed-off-by: Jeff Cody Thanks, applied to the block branch. Kevin