From: Eric Blake <eblake@redhat.com>
To: jcody@redhat.com
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image
Date: Tue, 16 Oct 2012 09:35:29 -0600 [thread overview]
Message-ID: <507D7EC1.806@redhat.com> (raw)
In-Reply-To: <507D7DDE.5010802@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On 10/16/2012 09:31 AM, Jeff Cody wrote:
>> Also, I raised another bug[1] about a bad error message regarding
>> top_bs, if the user passes a different spelling than the canonical name
>> of the active image. Is that worth fixing in this series, or is it okay
>> to leave it until you actually add support for committing the top image?
>>
>> [1] https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02067.html
>>
>
> Since this doesn't pose an actual issue now, I was planning on just
> addressing that with the stage-2 patches, since that will likely touch
> other related areas of the code anyway. If you have major heartburn
> over this, I'll change it now.
Nah, waiting is fine. As I said in the original bug report, it is only
a poor quality error message at the moment, and fixing it may be easier
once you have additional pieces in place for committing the active
image. I just wanted to make sure the report wasn't lost.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-16 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 14:44 [Qemu-devel] [PATCH v2 0/4] block-commit fixes Jeff Cody
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 1/4] block: make bdrv_find_backing_image compare canonical filenames Jeff Cody
2012-10-16 15:12 ` Eric Blake
2012-10-16 15:40 ` Jeff Cody
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image Jeff Cody
2012-10-16 15:22 ` Eric Blake
2012-10-16 15:31 ` Jeff Cody
2012-10-16 15:35 ` Eric Blake [this message]
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 3/4] qemu-iotests: qemu-io tests update for block-commit (040) Jeff Cody
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 4/4] qemu-iotests: add relative backing file tests " Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D7EC1.806@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).