From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO9B6-0000Fo-RS for qemu-devel@nongnu.org; Tue, 16 Oct 2012 11:35:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TO9B5-0002SR-KR for qemu-devel@nongnu.org; Tue, 16 Oct 2012 11:35:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO9B5-0002SL-Bf for qemu-devel@nongnu.org; Tue, 16 Oct 2012 11:35:31 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9GFZUSH021649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Oct 2012 11:35:30 -0400 Message-ID: <507D7EC1.806@redhat.com> Date: Tue, 16 Oct 2012 09:35:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <421ff837d7c7dc9f661d71b2606c25b5a2b8ac3c.1350398238.git.jcody@redhat.com> <507D7BB3.7090505@redhat.com> <507D7DDE.5010802@redhat.com> In-Reply-To: <507D7DDE.5010802@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig00F2734A1F011FF39B9F26B1" Subject: Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jcody@redhat.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig00F2734A1F011FF39B9F26B1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/16/2012 09:31 AM, Jeff Cody wrote: >> Also, I raised another bug[1] about a bad error message regarding >> top_bs, if the user passes a different spelling than the canonical nam= e >> of the active image. Is that worth fixing in this series, or is it ok= ay >> to leave it until you actually add support for committing the top imag= e? >> >> [1] https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02067.htm= l >> >=20 > Since this doesn't pose an actual issue now, I was planning on just > addressing that with the stage-2 patches, since that will likely touch > other related areas of the code anyway. If you have major heartburn > over this, I'll change it now. Nah, waiting is fine. As I said in the original bug report, it is only a poor quality error message at the moment, and fixing it may be easier once you have additional pieces in place for committing the active image. I just wanted to make sure the report wasn't lost. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig00F2734A1F011FF39B9F26B1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQfX7BAAoJEKeha0olJ0NqpswIAKwyNjSB7aQbZSaCdloBtFsY Uyz9hy7PpTh/7nRW9KwqlbYLRhc1/3dQStJueuY2I2bd6GkqIu6o3ezEBURsCTql +MhKllghrr6wnxIXHlnJsT+AXlh/fXnnHlcWROkunDCoHdn6iIyaEvvukjXf9m5k txgsIiAOLOSS/776FU2LGx0nu0Xx63T8pF7UaF6mGE25zQPKkCcD68WRalalykN/ nMLkXIfPSJJYTv4d6qfmJzcROOh+UXE81V3LCxaDegGbmXc3UA7DxWxBI8FvogAn JU2mKN+FCyBdO5DXgnCKR6hw8mDV3WZDa2L9uYZNw2MmWh9MVaQRRXI923x4z3A= =bTUm -----END PGP SIGNATURE----- --------------enig00F2734A1F011FF39B9F26B1--