From: Corey Bryant <coreyb@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/4] command line fd passing using fd sets
Date: Tue, 16 Oct 2012 15:45:18 -0400 [thread overview]
Message-ID: <507DB94E.7040400@linux.vnet.ibm.com> (raw)
In-Reply-To: <507DB4F2.3090309@redhat.com>
On 10/16/2012 03:26 PM, Eric Blake wrote:
> On 10/16/2012 11:51 AM, Corey Bryant wrote:
>> This series adds command line file descriptor passing support
>> via a new -add-fd option. This is a follow-on to the existing
>> QMP fd passing support provided in the following patch series:
>> comments.gmane.org/gmane.comp.emulators.qemu/165463
>>
>> The new -add-fd option is designed to mirror the add-fd QMP
>> option as much as possible.
>
> Before this can still be useful in libvirt, we need a way to pass in fds
> for all of a backing chain, and not just the top-level. And you can't
> argue that libvirt should be temporarily rewriting qcow2 metadata to
> stick in names such as /dev/fdset/1 into the metadata. Consider the
> case of:
>
> /- guest1.img
> base.img <- snap1.img <
> \- guest2.img
>
> snap1.img is supposed to be read-only, and there's no guarantee that
> /dev/fdset/1 will be available for both guest1 and guest2 to rewrite the
> header. Thus, I argue that snap1.img must encode the name base.img in
> its metadata, but that we must also have a way to tell qemu to open
> /dev/fdset/1 instead of trying open(base.img) in order to get the open
> fd for base.img.
I think the -blockdev command is going to solve this.
Stefan, do you have any information on the -blockdev support?
>
> But even though we are still not at a point where the overall feature is
> useful, I can at least review these patches for getting us incrementally
> closer to our goal.
>
Thanks Eric.
--
Regards,
Corey Bryant
prev parent reply other threads:[~2012-10-16 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 17:51 [Qemu-devel] [PATCH v3 0/4] command line fd passing using fd sets Corey Bryant
2012-10-16 19:26 ` Eric Blake
2012-10-16 19:45 ` Corey Bryant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507DB94E.7040400@linux.vnet.ibm.com \
--to=coreyb@linux.vnet.ibm.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).