From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TODp4-0001N5-6b for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TODp2-0001kw-W4 for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:33:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TODp2-0001kk-N7 for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:33:04 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9GKX330028664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Oct 2012 16:33:04 -0400 Message-ID: <507DC47E.9050505@redhat.com> Date: Tue, 16 Oct 2012 14:33:02 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig84229563CAB36B317C1916AD" Subject: Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig84229563CAB36B317C1916AD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/16/2012 01:49 PM, Jeff Cody wrote: > v2 -> v3 differences: >=20 > * Simplified code in patch 2, minor commit rewording > * Made conditional check more valgrind-friendly >=20 > v1 -> v2 differences: >=20 > * Updated changes to be protocol friendly > * Updated block-commit tests to account for different error message > wording > * Updated block-commit tests to add relative backing filename tests > * In bdrv_find_backing_image(), use g_malloc() instead of char arrays >=20 >=20 > Jeff Cody (4): > block: make bdrv_find_backing_image compare canonical filenames > block: in commit, determine base image from the top image > qemu-iotests: qemu-io tests update for block-commit (040) > qemu-iotests: add relative backing file tests for block-commit (040) Should patch 3/4 be squashed into 2/4 to avoid 'git bisect' failures when running the testsuite? Other than that, series: Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig84229563CAB36B317C1916AD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQfcR+AAoJEKeha0olJ0NqKtcIAK5xWGCCOXkosVtgKL0iTrfb VAAbOCxtzahNBXEEl9JzvAt7d7XM/5Xz9TQbpBoMZVSDqc/EAQKZ7dY5JQ/kE4hw lRd1ExDKVg+HgGBrw8ZIURh/Qz7O3FEQQTReVMmPxPt4dwL+hT1l7udd5liPllUK zVZ4vwPnCXeD0mWVG44ueVyBoZdOd1UWYOcebjrHNdtAQK7GU94/pXAFaTRBD7+t 7Sstq3lqA1NUuCkGJfTPZZWFoBxcl8eTk7zf1+6lZBeaJHIvkqxM+ft24FtjVbMT 5H0XoGweyWR6m3rZS1kPru854V+PYEwydRCG+k9QjKsc+UWRhOOXYTMUlKEjxLc= =giEQ -----END PGP SIGNATURE----- --------------enig84229563CAB36B317C1916AD--