From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOECS-0005eo-Mk for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOECR-0000Iq-Ju for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:57:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOECR-0000IY-AM for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:57:15 -0400 Message-ID: <507DCA22.8000302@redhat.com> Date: Tue, 16 Oct 2012 14:57:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350410885-2331-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1350410885-2331-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig39B28BB278C19E6BC512ACAB" Subject: Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig39B28BB278C19E6BC512ACAB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/16/2012 12:08 PM, Corey Bryant wrote: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. >=20 > Note: All of the code added to monitor_fdset_add_fd(), with the > exception of the error path for non-valid fdset-id, is code motion > from qmp_add_fd(). >=20 > Signed-off-by: Corey Bryant > --- > v2: > -Removed Error** parameter from monitor_fdset_add_fd() >=20 > v3: > -Added Error** parameter back to monitor_fdset_add_fd() > -Move 'if (!mon_fdset_cur)' change to patch 1 (kwolf@redhat.com) > -Move code that prevents removal of fd from fd set during init > to it's own patch (eblake@redhat.com, kwolf@redhat.com) > -Mention code motion in commit message (kwolf@redhat.com) Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig39B28BB278C19E6BC512ACAB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQfcoiAAoJEKeha0olJ0Nq1YcIAKHMzZpq9J/u26ZqeZiJJZKk XCh4A3OyOghqqS0f6yZ6V5P+VSsza0pM9iTZ23Q3aq3uukBxqbtqWIxTkF4uPGNa pRPn9RuksEcxK+JqO8lyoqfLtQnj4kXeg8ty5D+MswaDcz98o6g2ogPoX2ph4eYD lSOuAJ+t1TRPFmIvCA4cvdasIzgGnsykT7BvVg7WO42yMSqH9vgX4LrDC9ngy2IO bJvQfhZdODEtSK5CFlpwYJwLejPkq9Pkpr8jjHQ6D3Z92uFwCg8qKm8+rgunuCj/ 7NdlaBytcNvRB3U5A+HENitu3KaY0qTRJLKZ1sK5mBYSMiUwMUMUT209I2itEag= =bZc/ -----END PGP SIGNATURE----- --------------enig39B28BB278C19E6BC512ACAB--