From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOI8v-0001P1-1J for qemu-devel@nongnu.org; Tue, 16 Oct 2012 21:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOI8u-00062b-2W for qemu-devel@nongnu.org; Tue, 16 Oct 2012 21:09:52 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:43628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOI8t-00062W-QR for qemu-devel@nongnu.org; Tue, 16 Oct 2012 21:09:51 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so6470411pad.4 for ; Tue, 16 Oct 2012 18:09:51 -0700 (PDT) Sender: Richard Henderson Message-ID: <507E0558.80108@twiddle.net> Date: Wed, 17 Oct 2012 11:09:44 +1000 From: Richard Henderson MIME-Version: 1.0 References: <1349202750-16815-1-git-send-email-rth@twiddle.net> <1349202750-16815-11-git-send-email-rth@twiddle.net> <20121016232547.GA28153@ohm.aurel32.net> In-Reply-To: <20121016232547.GA28153@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 2012-10-17 09:25, Aurelien Jarno wrote: >> > + gen_opc_buf[op_index] = op = INDEX_op_mul_i32; > Very minor nitpick: you probably don't need to set op there. > Perhaps not, but I prefer to keep the variables in sync as we drop into common code... r~