From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TOQDE-0007M3-6c
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 05:46:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TOQD8-0007hn-7s
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 05:46:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TOQD8-0007hA-07
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 05:46:46 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9H9kikH015246
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 17 Oct 2012 05:46:44 -0400
Message-ID: <507E7E81.4070802@redhat.com>
Date: Wed, 17 Oct 2012 11:46:41 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <cover.1350416368.git.jcody@redhat.com>
	<507DC47E.9050505@redhat.com>
In-Reply-To: <507DC47E.9050505@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org

Am 16.10.2012 22:33, schrieb Eric Blake:
> On 10/16/2012 01:49 PM, Jeff Cody wrote:
>> v2 -> v3 differences:
>>
>> * Simplified code in patch 2, minor commit rewording
>> * Made conditional check more valgrind-friendly
>>
>> v1 -> v2 differences:
>>
>> * Updated changes to be protocol friendly
>> * Updated block-commit tests to account for different error message
>>   wording
>> * Updated block-commit tests to add relative backing filename tests
>> * In bdrv_find_backing_image(), use g_malloc() instead of char arrays
>>
>>
>> Jeff Cody (4):
>>   block: make bdrv_find_backing_image compare canonical filenames
>>   block: in commit, determine base image from the top image
>>   qemu-iotests: qemu-io tests update for block-commit (040)
>>   qemu-iotests: add relative backing file tests for block-commit (040)
> 
> Should patch 3/4 be squashed into 2/4 to avoid 'git bisect' failures
> when running the testsuite?  Other than that, series:

Yes, I agree. Applied all and squashed 3/4 into 2/4.

Kevin