From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TORKx-0007FT-T7 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 06:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TORKt-00056M-CH for qemu-devel@nongnu.org; Wed, 17 Oct 2012 06:58:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TORKt-00055R-4H for qemu-devel@nongnu.org; Wed, 17 Oct 2012 06:58:51 -0400 Message-ID: <507E8F60.4010508@redhat.com> Date: Wed, 17 Oct 2012 12:58:40 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1349202750-16815-1-git-send-email-rth@twiddle.net> <1349202750-16815-11-git-send-email-rth@twiddle.net> <20121016232547.GA28153@ohm.aurel32.net> <507E0558.80108@twiddle.net> In-Reply-To: <507E0558.80108@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, Aurelien Jarno On 10/17/2012 03:09 AM, Richard Henderson wrote: > On 2012-10-17 09:25, Aurelien Jarno wrote: >>> > + gen_opc_buf[op_index] = op = INDEX_op_mul_i32; >> Very minor nitpick: you probably don't need to set op there. >> > > Perhaps not, but I prefer to keep the variables in sync as we > drop into common code... The compiler should recognize the dead variable anyway. How very meta. -- error compiling committee.c: too many arguments to function