From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket
Date: Wed, 17 Oct 2012 13:04:56 +0200 [thread overview]
Message-ID: <507E90D8.8050405@redhat.com> (raw)
In-Reply-To: <1350297511-25437-14-git-send-email-hdegoede@redhat.com>
On 10/15/12 12:38, Hans de Goede wrote:
> - usb_packet_setup(&xfer->packet, dir, ep, xfer->trbs[0].addr, false);
> + int_req = false;
> + for (i = 0; i < xfer->trb_count; i++) {
> + if (xfer->trbs[i].control & TRB_TR_IOC) {
> + int_req = true;
> + break;
> + }
> + }
Guess we better add a new int_req field to XHCITransfer and fill it when
walking the trb list _anyway_, so we don't have to loop again.
cheers,
Gerd
next prev parent reply other threads:[~2012-10-17 11:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 10:38 [Qemu-devel] RFC: usb input pipelining / speedup patchset v2 Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 01/22] uhci: Properly unmap packets on cancel / invalid pid Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 02/22] uhci: Move checks to continue queuing to uhci_fill_queue() Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 03/22] ehci: Get rid of packet tbytes field Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 04/22] ehci: Set int flag on a short input packet Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 05/22] ehci: Improve latency of interrupt delivery and async schedule scanning Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule Hans de Goede
2012-10-15 11:17 ` Gerd Hoffmann
2012-10-15 13:00 ` Hans de Goede
2012-10-17 11:01 ` Gerd Hoffmann
2012-10-17 11:11 ` Hans de Goede
2012-10-17 11:37 ` Gerd Hoffmann
2012-10-15 10:38 ` [Qemu-devel] [PATCH 07/22] ehci: Detect going in circles when filling the queue Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 08/22] xhci: Add a xhci_ep_nuke_one_xfer helper function Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 09/22] usb: Rename __usb_packet_complete to usb_packet_complete_one Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 10/22] usb: Add USB_RET_ADD_TO_QUEUE packet result code Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 11/22] usb: Move clearing of queue on halt to the core Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 12/22] usb: Move short-not-ok handling " Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket Hans de Goede
2012-10-17 11:04 ` Gerd Hoffmann [this message]
2012-10-17 11:11 ` Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions Hans de Goede
2012-10-17 11:29 ` Gerd Hoffmann
2012-10-17 14:41 ` Hans de Goede
2012-10-18 6:00 ` Gerd Hoffmann
2012-10-15 10:38 ` [Qemu-devel] [PATCH 15/22] combined-packet: Add a workaround for Linux usbfs + live migration Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 16/22] usb-redir: When a packet contains data on a stall, ignore the stall Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 17/22] usb-redir: Add support for 32 bits bulk packet length Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 18/22] usb-redir: Add support for input pipelining Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 19/22] usb-redir: Add an usbredir_setup_usb_eps() helper function Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 20/22] usb-redir: Use reject rather the disconnect on bad ep info Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 21/22] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller Hans de Goede
2012-10-15 10:38 ` [Qemu-devel] [PATCH 22/22] usb-redir: Allow redirecting super speed devices to high speed controllers Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507E90D8.8050405@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).