From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58946)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TORW3-0003KW-W9
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 07:10:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TORVy-000058-89
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 07:10:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TORVx-000050-Vk
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 07:10:18 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HBAHU0008420
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 17 Oct 2012 07:10:17 -0400
Message-ID: <507E9278.3070905@redhat.com>
Date: Wed, 17 Oct 2012 13:11:52 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1350297511-25437-1-git-send-email-hdegoede@redhat.com>
	<1350297511-25437-14-git-send-email-hdegoede@redhat.com>
	<507E90D8.8050405@redhat.com>
In-Reply-To: <507E90D8.8050405@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi,

On 10/17/2012 01:04 PM, Gerd Hoffmann wrote:
> On 10/15/12 12:38, Hans de Goede wrote:
>> -    usb_packet_setup(&xfer->packet, dir, ep, xfer->trbs[0].addr, false);
>> +    int_req = false;
>> +    for (i = 0; i < xfer->trb_count; i++) {
>> +        if (xfer->trbs[i].control & TRB_TR_IOC) {
>> +            int_req = true;
>> +            break;
>> +        }
>> +    }
>
> Guess we better add a new int_req field to XHCITransfer and fill it when
> walking the trb list _anyway_, so we don't have to loop again.

Ok, I will fix this for the next respin of the patchset.

Regards,

Hans