From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTZS-0000BK-Mj for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOTZM-0004Ng-Ou for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:22:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTZM-0004Nc-Gx for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:21:56 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HDLtwW002658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 09:21:56 -0400 Message-ID: <507EB0EF.307@redhat.com> Date: Wed, 17 Oct 2012 15:21:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349275025-5093-1-git-send-email-pbonzini@redhat.com> <1349275025-5093-4-git-send-email-pbonzini@redhat.com> <87txtt6xw6.fsf@blackfin.pond.sub.org> In-Reply-To: <87txtt6xw6.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connect are portable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Il 17/10/2012 15:17, Markus Armbruster ha scritto: >> > They are just wrappers and do not need a Win32-specific version. > This gave me pause (it's my thick-headed day, apparently), until I > realized that in addition to what the commit message says you also move > related code. Please try harder to make review as easy as possible. I don't, it's just git that decided to make the diff this way. :) Paolo