From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTp2-0000z4-Gx for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOTou-0000rj-27 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:38:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTot-0000rd-QD for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:37:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HDbxWf029412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 09:37:59 -0400 Message-ID: <507EB4B3.1000205@redhat.com> Date: Wed, 17 Oct 2012 15:37:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349877786-23514-1-git-send-email-pbonzini@redhat.com> <1349877786-23514-6-git-send-email-pbonzini@redhat.com> <87bog1z0cz.fsf@blackfin.pond.sub.org> In-Reply-To: <87bog1z0cz.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Il 17/10/2012 15:36, Markus Armbruster ha scritto: >> > The migration code is using errp to detect "internal" errors, >> > this means that it relies on errp being non-NULL. > Impact? None because so far our only QMP client is HMP and never passes a NULL Error **. But if we had others, it would make sure migration can work with a NULL Error **. Paolo