From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTwy-0005Ho-Mk for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOTwu-0004AK-PD for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:46:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTwu-00049z-5j for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:46:16 -0400 Message-ID: <507EB688.80308@redhat.com> Date: Wed, 17 Oct 2012 15:45:44 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1350410885-2331-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1350410885-2331-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: libvir-list@redhat.com, qemu-devel@nongnu.org Am 16.10.2012 20:08, schrieb Corey Bryant: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > Note: All of the code added to monitor_fdset_add_fd(), with the > exception of the error path for non-valid fdset-id, is code motion > from qmp_add_fd(). > > Signed-off-by: Corey Bryant And the non-valid fdset-id error case leaks fd now, right? Kevin