From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOUu0-0004Oj-Ro for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:47:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOUtr-0005xD-A1 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:47:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOUtr-0005x5-0V for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:47:11 -0400 Message-ID: <507EC4E5.9050505@redhat.com> Date: Wed, 17 Oct 2012 16:47:01 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1350475352-9607-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1350475352-9607-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/2] qemu-img: Add --backing-chain option to info command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kashyap.cv@gmail.com, qemu-devel@nongnu.org, =?ISO-8859-15?Q?Beno=EEt_Canet?= Am 17.10.2012 14:02, schrieb Stefan Hajnoczi: > This series adds the --backing-chain option for enumerating the backing file > chain. Given the topmost image it will print qemu-img info information for > each image file in the chain. > > Special care needs to be taken when image files form an infinite loop. This is > very unusual, most like due to malicious image files. Nevertheless, qemu-img > must be robust against invalid inputs so we explicit check for this. > > v3: > * Use ImageInfoList to avoid manually outputting JSON and to make the code > more QAPI-friendly. > * Solve the output vs error messages issues by printing a detailed error > message but no image info. To dig into a broken image chain, rerun without > --backing-chain. This is different from what I initially tried but is much > cleaner because it doesn't produce confusing output. > * rm -f $TEST_IMG.[123].base [Kevin] > * Include --output=json in test case [Kevin] > * Rename test case to free 043 number [Eric] > > Stefan Hajnoczi (2): > qemu-img: Add --backing-chain option to info command > qemu-iotests: Add 043 backing file chain infinite loop test > > qemu-img.c | 167 +++++++++++++++++++++++++++++++++++++++---- > tests/qemu-iotests/043 | 94 ++++++++++++++++++++++++ > tests/qemu-iotests/043.out | 66 +++++++++++++++++ > tests/qemu-iotests/common.rc | 10 +++ > tests/qemu-iotests/group | 1 + > 5 files changed, 324 insertions(+), 14 deletions(-) > create mode 100755 tests/qemu-iotests/043 > create mode 100644 tests/qemu-iotests/043.out Thanks applied both to the block branch. Kevin