qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-ppc@nongnu.org List" <qemu-ppc@nongnu.org>,
	qemu-devel qemu-devel <qemu-devel@nongnu.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Memory-API: Make eventfd adhere to device endianness
Date: Wed, 17 Oct 2012 16:47:43 +0200	[thread overview]
Message-ID: <507EC50F.8090909@redhat.com> (raw)
In-Reply-To: <1350325828-11577-1-git-send-email-agraf@suse.de>

On 10/15/2012 08:30 PM, Alexander Graf wrote:
> Our memory API MMIO regions know the concept of device endianness. This
> is used to automatically swap endianness between devices and host CPU,
> depending on whether buses in between would swizzle the bits.
> 
> The ioeventfd value comparison does not adhere to that semantic though.
> Probably because nobody has been running ioeventfd on a BE platform and
> the only device implementing ioeventfd right now is LE (PCI) based.
> 
> So add swizzling to ioeventfd registration / deletion to make the rest
> of the code as consistent as possible.
> 
> Thanks a lot to Michael Tsirkin to point me towards the right direction.

Thanks, applied.


-- 
error compiling committee.c: too many arguments to function

      reply	other threads:[~2012-10-17 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 18:30 [Qemu-devel] [PATCH] Memory-API: Make eventfd adhere to device endianness Alexander Graf
2012-10-17 14:47 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507EC50F.8090909@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).