From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOUua-00057e-K9 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOUuR-00065X-1J for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:47:56 -0400 Message-ID: <507EC50F.8090909@redhat.com> Date: Wed, 17 Oct 2012 16:47:43 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1350325828-11577-1-git-send-email-agraf@suse.de> In-Reply-To: <1350325828-11577-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Memory-API: Make eventfd adhere to device endianness List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org List" , qemu-devel qemu-devel , "Michael S. Tsirkin" On 10/15/2012 08:30 PM, Alexander Graf wrote: > Our memory API MMIO regions know the concept of device endianness. This > is used to automatically swap endianness between devices and host CPU, > depending on whether buses in between would swizzle the bits. > > The ioeventfd value comparison does not adhere to that semantic though. > Probably because nobody has been running ioeventfd on a BE platform and > the only device implementing ioeventfd right now is LE (PCI) based. > > So add swizzling to ioeventfd registration / deletion to make the rest > of the code as consistent as possible. > > Thanks a lot to Michael Tsirkin to point me towards the right direction. Thanks, applied. -- error compiling committee.c: too many arguments to function