From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOVVs-0008Rs-5x for qemu-devel@nongnu.org; Wed, 17 Oct 2012 11:26:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOVVj-0000n4-UG for qemu-devel@nongnu.org; Wed, 17 Oct 2012 11:26:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOVVj-0000my-Kt for qemu-devel@nongnu.org; Wed, 17 Oct 2012 11:26:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HFQIXI013520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 11:26:18 -0400 Message-ID: <507ECE19.1050706@redhat.com> Date: Wed, 17 Oct 2012 09:26:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350468595-5238-1-git-send-email-kraxel@redhat.com> <1350468595-5238-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1350468595-5238-4-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF624A24DC708F9A665664C3D" Subject: Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF624A24DC708F9A665664C3D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/17/2012 04:09 AM, Gerd Hoffmann wrote: > This patch adds chardev_add and chardev_remove monitor commands. >=20 > They work similar to the netdev_{add,del} commands. The hmp version of= > chardev_add accepts like the -chardev command line option does. The qm= p > version expects the arguments being passed as named parameters. >=20 > chardev_del just takes an id argument and zaps the chardev specified. >=20 > Signed-off-by: Gerd Hoffmann > --- > +## > +# @chardev-add: > +# > +# Add a chardev > +# > +# @id: the chardev's ID, must be unique > +# @backend: the chardev backend: "file", "socket", ... This still needs to be an enum. > +# @path: file / device / unix socket path > +# @name: spice channel name > +# @host: host name > +# @port: port number > +# @server: create socket in server mode > +# @wait: wait for connect > +# @ipv4: force ipv4-only > +# @ipv6: force ipv6-only > +# @telnet: telnet negotiation But this part looks nicer. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF624A24DC708F9A665664C3D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQfs4ZAAoJEKeha0olJ0NqtwIH/306Cs74x7Nd/hkkmflXuMk5 FxxkVLLGZvpMVglH/c2nZJzqPC/Dlz33Fnta+l3IMiWXY9lCB9kD6ZZmFLQNMiEh e6XduekEgbP31NFQM6Akx+BG92CfyjzqBRCoR0qzojOKOcKy5KvsZMKz86UtA2j0 bmNmTX008Ib13HVhtZRmCiL2vV4/SQUtshxl48tZaXQRxmlgck1UD18d/1cIhve/ VgcPXXUY7t7cnJUKE1dhyY7so5Bp/sAYgqYHAHboBEKhHbWGy0qQSxzCtbim8fVj z305dNK4UNWutbPfDWc/8lt+Y3UBP9vbtsbdgRJj2VfZXjfUGNgPiEKN9s/9IdE= =WSK4 -----END PGP SIGNATURE----- --------------enigF624A24DC708F9A665664C3D--