From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOVtT-00082y-84 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 11:51:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOVtN-000841-5o for qemu-devel@nongnu.org; Wed, 17 Oct 2012 11:50:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOVtM-00083w-Te for qemu-devel@nongnu.org; Wed, 17 Oct 2012 11:50:45 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HFohua003029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 11:50:44 -0400 Message-ID: <507ED3D1.6000405@redhat.com> Date: Wed, 17 Oct 2012 17:50:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349877786-23514-1-git-send-email-pbonzini@redhat.com> <1349877786-23514-16-git-send-email-pbonzini@redhat.com> <87y5j5w1hp.fsf@blackfin.pond.sub.org> In-Reply-To: <87y5j5w1hp.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/25] qemu-sockets: add error propagation to inet_connect_addr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Il 17/10/2012 17:40, Markus Armbruster ha scritto: >> > if (s->current_addr) { >> > while (s->current_addr->ai_next != NULL && s->fd < 0) { >> > s->current_addr = s->current_addr->ai_next; >> > - s->fd = inet_connect_addr(s->current_addr, &in_progress, s); >> > + s->fd = inet_connect_addr(s->current_addr, &in_progress, s, NULL); > Doesn't this drop error messages? Depends on what you mean by drop. The error messages previously were sent to stdio, hidden in a log file or just invisible, depending on how QEMU is run. (This is just for outgoing migration currently, so you cannot rely on stdio as you can for command-line parsing). > If yes, but it's healed later in the series, the temporary breakage > still needs to be spelled out in the commit message. No, it's not healed, which is why it's mentioned in the commit message that future work is needed. Paolo