qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
Date: Wed, 17 Oct 2012 18:28:04 +0200	[thread overview]
Message-ID: <507EDC94.6050505@redhat.com> (raw)
In-Reply-To: <507ECE19.1050706@redhat.com>

Il 17/10/2012 17:26, Eric Blake ha scritto:
> On 10/17/2012 04:09 AM, Gerd Hoffmann wrote:
>> This patch adds chardev_add and chardev_remove monitor commands.
>>
>> They work similar to the netdev_{add,del} commands.  The hmp version of
>> chardev_add accepts like the -chardev command line option does.  The qmp
>> version expects the arguments being passed as named parameters.
>>
>> chardev_del just takes an id argument and zaps the chardev specified.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
> 
>> +##
>> +# @chardev-add:
>> +#
>> +# Add a chardev
>> +#
>> +# @id: the chardev's ID, must be unique
>> +# @backend: the chardev backend: "file", "socket", ...
> 
> This still needs to be an enum.
> 
>> +# @path: file / device / unix socket path
>> +# @name: spice channel name
>> +# @host: host name
>> +# @port: port number
>> +# @server: create socket in server mode
>> +# @wait: wait for connect
>> +# @ipv4: force ipv4-only
>> +# @ipv6: force ipv6-only
>> +# @telnet: telnet negotiation
> 
> But this part looks nicer.

Note that this schema is just for documentation.  It is not used at QEMU
build time.

Paolo

  reply	other threads:[~2012-10-17 16:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 10:09 [Qemu-devel] [PATCH 0/3] chardev hotplug patch series Gerd Hoffmann
2012-10-17 10:09 ` [Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts Gerd Hoffmann
2012-10-17 16:22   ` Luiz Capitulino
2012-10-17 10:09 ` [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle Gerd Hoffmann
2012-10-17 16:40   ` Luiz Capitulino
2012-10-18  9:26     ` Gerd Hoffmann
2012-10-18 13:30       ` Luiz Capitulino
2012-10-17 10:09 ` [Qemu-devel] [PATCH 3/3] chardev: add hotplug support Gerd Hoffmann
2012-10-17 15:26   ` Eric Blake
2012-10-17 16:28     ` Paolo Bonzini [this message]
2012-10-18 10:03   ` Gerd Hoffmann
2012-10-18 18:44     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2012-12-14  9:38 [Qemu-devel] [PATCH RESENT 0/3] chardev hotplug patch series Gerd Hoffmann
2012-12-14  9:38 ` [Qemu-devel] [PATCH 3/3] chardev: add hotplug support Gerd Hoffmann
2012-12-14 12:17   ` Paolo Bonzini
2012-12-14 13:05     ` Eric Blake
2012-12-14 13:18     ` Gerd Hoffmann
2012-12-14 13:45       ` Paolo Bonzini
2012-12-14 14:05         ` Gerd Hoffmann
2012-12-14 14:19           ` Gerd Hoffmann
2012-12-14 15:07             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507EDC94.6050505@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).