From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TOWTk-0008Tq-CY
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 12:28:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TOWTb-0003tB-F4
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 12:28:20 -0400
Received: from mail-pa0-f45.google.com ([209.85.220.45]:38471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TOWTb-0003t3-8K
	for qemu-devel@nongnu.org; Wed, 17 Oct 2012 12:28:11 -0400
Received: by mail-pa0-f45.google.com with SMTP id fb10so7325176pad.4
	for <qemu-devel@nongnu.org>; Wed, 17 Oct 2012 09:28:10 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <507EDC94.6050505@redhat.com>
Date: Wed, 17 Oct 2012 18:28:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350468595-5238-1-git-send-email-kraxel@redhat.com>
	<1350468595-5238-4-git-send-email-kraxel@redhat.com>
	<507ECE19.1050706@redhat.com>
In-Reply-To: <507ECE19.1050706@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

Il 17/10/2012 17:26, Eric Blake ha scritto:
> On 10/17/2012 04:09 AM, Gerd Hoffmann wrote:
>> This patch adds chardev_add and chardev_remove monitor commands.
>>
>> They work similar to the netdev_{add,del} commands.  The hmp version of
>> chardev_add accepts like the -chardev command line option does.  The qmp
>> version expects the arguments being passed as named parameters.
>>
>> chardev_del just takes an id argument and zaps the chardev specified.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
> 
>> +##
>> +# @chardev-add:
>> +#
>> +# Add a chardev
>> +#
>> +# @id: the chardev's ID, must be unique
>> +# @backend: the chardev backend: "file", "socket", ...
> 
> This still needs to be an enum.
> 
>> +# @path: file / device / unix socket path
>> +# @name: spice channel name
>> +# @host: host name
>> +# @port: port number
>> +# @server: create socket in server mode
>> +# @wait: wait for connect
>> +# @ipv4: force ipv4-only
>> +# @ipv6: force ipv6-only
>> +# @telnet: telnet negotiation
> 
> But this part looks nicer.

Note that this schema is just for documentation.  It is not used at QEMU
build time.

Paolo