From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOlho-0006ES-EO for qemu-devel@nongnu.org; Thu, 18 Oct 2012 04:43:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOlhk-0004fJ-F2 for qemu-devel@nongnu.org; Thu, 18 Oct 2012 04:43:52 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:49018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOlhk-0004fD-8x for qemu-devel@nongnu.org; Thu, 18 Oct 2012 04:43:48 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so8158108pad.4 for ; Thu, 18 Oct 2012 01:43:47 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <507FC13C.1030401@redhat.com> Date: Thu, 18 Oct 2012 10:43:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1350545426-23172-1-git-send-email-quintela@redhat.com> <1350545426-23172-29-git-send-email-quintela@redhat.com> In-Reply-To: <1350545426-23172-29-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 28/30] fix memory.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org Il 18/10/2012 09:30, Juan Quintela ha scritto: > Signed-off-by: Juan Quintela > --- > memory.c | 4 +++- > memory.h | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/memory.c b/memory.c > index 126fb63..4d0fa96 100644 > --- a/memory.c > +++ b/memory.c > @@ -1089,7 +1089,9 @@ bool memory_region_test_and_clear_dirty(MemoryRegion *mr, > ret = cpu_physical_memory_get_dirty(mr->ram_addr + addr, size, > 1 << client); > if (ret) { > - cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1); > + cpu_physical_memory_reset_dirty(mr->ram_addr + addr, > + mr->ram_addr + addr + size, > + 1 << client); > } > return ret; > } > diff --git a/memory.h b/memory.h > index 08af012..0dcc0f4 100644 > --- a/memory.h > +++ b/memory.h > @@ -449,7 +449,8 @@ void memory_region_set_dirty(MemoryRegion *mr, target_phys_addr_t addr, > */ > bool memory_region_test_and_clear_dirty(MemoryRegion *mr, > target_phys_addr_t addr, > - target_phys_addr_t size, unsigned client) > + target_phys_addr_t size, > + unsigned client); > /** > * memory_region_sync_dirty_bitmap: Synchronize a region's dirty bitmap with > * any external TLBs (e.g. kvm) > This should be squashed in patch 26. Paolo