From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOox4-0007Wb-RV for qemu-devel@nongnu.org; Thu, 18 Oct 2012 08:11:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOowy-0000Dc-Ea for qemu-devel@nongnu.org; Thu, 18 Oct 2012 08:11:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOowy-0000DW-6e for qemu-devel@nongnu.org; Thu, 18 Oct 2012 08:11:44 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9ICBhYb026280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Oct 2012 08:11:43 -0400 Message-ID: <507FF1FC.1060502@redhat.com> Date: Thu, 18 Oct 2012 14:11:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1350502556-4885-1-git-send-email-lcapitulino@redhat.com> <1350502556-4885-6-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1350502556-4885-6-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Am 17.10.2012 21:35, schrieb Luiz Capitulino: > Signed-off-by: Luiz Capitulino > --- > qemu-img.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 12fb6c2..dfde588 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -302,6 +302,7 @@ static int img_create(int argc, char **argv) > const char *base_filename = NULL; > char *options = NULL; > QEMUOptionParameter *params = NULL; > + Error *local_err = NULL; > > for(;;) { > c = getopt(argc, argv, "F:b:f:he6o:"); > @@ -362,9 +363,12 @@ static int img_create(int argc, char **argv) > goto out; > } > > - ret = bdrv_img_create(filename, fmt, base_filename, base_fmt, > - options, img_size, BDRV_O_FLAGS, ¶ms, NULL); > - if (ret < 0) { > + bdrv_img_create(filename, fmt, base_filename, base_fmt, > + options, img_size, BDRV_O_FLAGS, ¶ms, &local_err); > + if (error_is_set(&local_err)) { > + fprintf(stderr, "qemu-img: %s\n", error_get_pretty(local_err)); This should use error_report() instead of adding the "qemu-img:" manually. Kevin