From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOp21-0001kX-NH for qemu-devel@nongnu.org; Thu, 18 Oct 2012 08:17:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOp1s-0001ub-6e for qemu-devel@nongnu.org; Thu, 18 Oct 2012 08:16:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOp1r-0001uU-Uu for qemu-devel@nongnu.org; Thu, 18 Oct 2012 08:16:48 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9ICGl4Y000536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Oct 2012 08:16:47 -0400 Message-ID: <507FF32B.6060509@redhat.com> Date: Thu, 18 Oct 2012 14:16:43 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1350502556-4885-1-git-send-email-lcapitulino@redhat.com> <1350502556-4885-4-git-send-email-lcapitulino@redhat.com> <507FEFA3.4040000@redhat.com> In-Reply-To: <507FEFA3.4040000@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move parameter list printing to qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Am 18.10.2012 14:01, schrieb Kevin Wolf: > Am 17.10.2012 21:35, schrieb Luiz Capitulino: >> Today, bdrv_img_create() prints the parameter list used to create the >> new image to stdout, like this: >> >> Formatting '/tmp/a', fmt=qcow2 size=10737418240 encryption=off cluster_size=65536 lazy_refcounts=off >> >> As the transaction QMP command calls bdrv_img_create(), this message >> is also printed when using QMP. >> >> This commit moves the printing of the parameter list to qemu-img instead. >> This way we avoid printing it in QMP and from whatever bdrv_img_create() >> usage we might have in the future. >> >> Signed-off-by: Luiz Capitulino > > I believe the idea was that this message is printed before actually > creating the image, which in the case of preallocation could take a while. The other thing is that I think you don't print the message any more when creating the image fails. Did you check that qemu-iotests doesn't need any updates? Kevin