From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56522)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TOpvE-00011S-VG
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:14:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TOpv9-00034v-7Q
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:14:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3166)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TOpv8-00033v-Vk
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:13:55 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IDDs63019177
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 18 Oct 2012 09:13:54 -0400
Message-ID: <50800090.80804@redhat.com>
Date: Thu, 18 Oct 2012 15:13:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com>
	<1348675011-8794-28-git-send-email-pbonzini@redhat.com>
	<507C48E9.4040901@redhat.com>
In-Reply-To: <507C48E9.4040901@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jcody@redhat.com, qemu-devel@nongnu.org

Il 15/10/2012 19:33, Kevin Wolf ha scritto:
> 
>> > +    source = bs->backing_hd;
>> > +    if (!source && sync == MIRROR_SYNC_MODE_TOP) {
>> > +        sync = MIRROR_SYNC_MODE_FULL;
>> > +    }
>> > +
>> > +    proto_drv = bdrv_find_protocol(target);
>> > +    if (!proto_drv) {
>> > +        error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
> Not a great error message for this case.

Hmm, this is cut-and-paste from qmp_transaction.

I will add an Error ** to bdrv_find_format and bdrv_find_protocol when I
have some time (certainly before 1.3).

Paolo