From: Corey Bryant <coreyb@linux.vnet.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set
Date: Thu, 18 Oct 2012 09:51:06 -0400 [thread overview]
Message-ID: <5080094A.5090406@linux.vnet.ibm.com> (raw)
In-Reply-To: <507EB688.80308@redhat.com>
On 10/17/2012 09:45 AM, Kevin Wolf wrote:
> Am 16.10.2012 20:08, schrieb Corey Bryant:
>> qmp_add_fd() gets an fd that was received over a socket with
>> SCM_RIGHTS and adds it to an fd set. This patch adds support
>> that will enable adding an fd that was inherited on the
>> command line to an fd set.
>>
>> Note: All of the code added to monitor_fdset_add_fd(), with the
>> exception of the error path for non-valid fdset-id, is code motion
>> from qmp_add_fd().
>>
>> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
>
> And the non-valid fdset-id error case leaks fd now, right?
>
> Kevin
>
Yes, I need to fix that. Thanks. I'll send out a v4.
--
Regards,
Corey Bryant
prev parent reply other threads:[~2012-10-18 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 18:08 [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set Corey Bryant
2012-10-16 20:57 ` Eric Blake
2012-10-17 13:45 ` Kevin Wolf
2012-10-18 13:51 ` Corey Bryant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080094A.5090406@linux.vnet.ibm.com \
--to=coreyb@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).