From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOqVL-000822-DI for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:51:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOqVD-0006XJ-6L for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:51:19 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:40916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOqVD-0006XF-1v for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:51:11 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Oct 2012 09:51:10 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 489626E8043 for ; Thu, 18 Oct 2012 09:51:07 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9IDp7w2321018 for ; Thu, 18 Oct 2012 09:51:07 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9IDp6Am011668 for ; Thu, 18 Oct 2012 10:51:06 -0300 Message-ID: <5080094A.5090406@linux.vnet.ibm.com> Date: Thu, 18 Oct 2012 09:51:06 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1350410885-2331-1-git-send-email-coreyb@linux.vnet.ibm.com> <507EB688.80308@redhat.com> In-Reply-To: <507EB688.80308@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: libvir-list@redhat.com, qemu-devel@nongnu.org On 10/17/2012 09:45 AM, Kevin Wolf wrote: > Am 16.10.2012 20:08, schrieb Corey Bryant: >> qmp_add_fd() gets an fd that was received over a socket with >> SCM_RIGHTS and adds it to an fd set. This patch adds support >> that will enable adding an fd that was inherited on the >> command line to an fd set. >> >> Note: All of the code added to monitor_fdset_add_fd(), with the >> exception of the error path for non-valid fdset-id, is code motion >> from qmp_add_fd(). >> >> Signed-off-by: Corey Bryant > > And the non-valid fdset-id error case leaks fd now, right? > > Kevin > Yes, I need to fix that. Thanks. I'll send out a v4. -- Regards, Corey Bryant