From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOtKE-0003wS-FE for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:52:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOtKD-0007PO-51 for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:52:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOtKC-0007PH-Qy for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:52:01 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IGq076026706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Oct 2012 12:52:00 -0400 Message-ID: <508033AF.4030906@redhat.com> Date: Thu, 18 Oct 2012 10:51:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350571770-9836-1-git-send-email-pbonzini@redhat.com> <1350571770-9836-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1350571770-9836-6-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig440AB5A793A10231FFBB540D" Subject: Re: [Qemu-devel] [PATCH v3 05/16] block: export dirty bitmap information in query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig440AB5A793A10231FFBB540D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > v2->v3: unit of measure is now bytes >=20 > block.c | 7 +++++++ > qapi-schema.json | 20 ++++++++++++++++++-- > 2 file modificati, 25 inserzioni(+), 2 rimozioni(-) >=20 > +++ b/qapi-schema.json > @@ -629,7 +629,7 @@ > '*backing_file': 'str', 'backing_file_depth': 'int', > 'encrypted': 'bool', 'encryption_key_missing': 'bool', > 'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int', > - 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} } > + 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int' } } > =20 This whitespace change hunk looks out of place... > ## > # @BlockDeviceIoStatus: > @@ -647,6 +647,18 @@ > { 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ]= } > =20 > ## > +# @BlockDirtyInfo: > +# > +# Block dirty bitmap information. > +# > +# @count: number of dirty bytes according to the dirty bitmap > +# > +# Since: 1.3 > +## > +{ 'type': 'BlockDirtyInfo', > + 'data': {'count': 'int'} } =2E..especially since you aren't consistent on using space before } However, I can live with it, rather than needing a v4. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig440AB5A793A10231FFBB540D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQgDOvAAoJEKeha0olJ0NqTIsH/jI8x5t50cIyMvUwEcIGlZou yK+e92kn+VFJt9CRQKCZugIGZDQn/QXvILi2SFZrwsXlxbvEc0qAAg6D99vsVVla lhx2wQ0xfTWQ6wSdWg+v/tS+Jj5xVpKlK1DN4/ZYjy733Eu5Q4I496EtKM3tAIm8 heWL42fnTafiY0wH8sa6kZlkTyW/PLArhEjoV/lXbHNmpy6WpcOTAGBdUUQU52it 4tPSv9HZn87AE4tx81AsUSY49h7Lh+SrjPh6FD1V6ry7jia3qmRrF+FZRX2fibVb 74SkRjP8ql0+J8noTM483mgFXksn4khsk1oBWK+uIIHLHfO9PtUVb4Ae8t5yU/k= =Aj/T -----END PGP SIGNATURE----- --------------enig440AB5A793A10231FFBB540D--