From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOtQY-00077W-Fp for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:58:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOtQU-0001DF-12 for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:58:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOtQT-0001D5-O4 for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:58:29 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IGwSBT029698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Oct 2012 12:58:28 -0400 Message-ID: <50803533.3070904@redhat.com> Date: Thu, 18 Oct 2012 10:58:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350571770-9836-1-git-send-email-pbonzini@redhat.com> <1350571770-9836-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1350571770-9836-9-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2D2E61241FA467620DB14AAB" Subject: Re: [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2D2E61241FA467620DB14AAB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > Even for jobs that need to be manually completed, management may want > to take care itself of the completion, not requiring the user to issue > a command to terminate the job. In this case we want to avoid that > they poll us continuously, waiting for completion to become available. > Thus, add a new event that signals the phase switch and the availabilit= y > of the block-job-complete command. >=20 > Signed-off-by: Paolo Bonzini > +BLOCK_JOB_READY > +--------------- > + > +Emitted when a block job is ready to complete. > + > +Data: > + > +- "device": device name (json-string) > + > +Example: > + > +{ "event": "BLOCK_JOB_READY", > + "data": { "device": "ide0-hd1", > + "operation": "write", > + "action": "stop" }, This example does not match the Data above ('operation' and 'action' were not documented. > + "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } Just a reminder that libvirt would still like a followup patch later in your series but prior to qemu 1.3 that adds a 'type':'str' (or even an enum, with 'stream', 'commit', and 'mirror'). But we already agreed it need not hold up this particular patch. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2D2E61241FA467620DB14AAB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQgDUzAAoJEKeha0olJ0NqVEsIAKlBlZH3Dod2xRlIvMKNdBQJ EejHgkj9Dbj13TNM5ksMfAeTTZTAwpPGjAXcWnKPwS1AeSsQh9os1pD+BZfpER6Z HP0g6/s+MSGn8JEda4TR8Y6ZBK/Adse+/PIWC0zb8npvMWlFgJfsxJfuwj5sG65Y I6KHLsTrG5SdtSsf6iX0L39kdZtJq/gCL9m4iDWeoRfoWxKJXggsvTAexZk7ogcq 7KSoRrOFltsllB+qcS688VGxnC1m87HZcfZSCySjIICBzv7bJfec0L8Pbd7oQX16 fumAKH4cZN5aJ5KJ6Ppw4RWobbCBOVrv91v2OwTnoDB7Udojqjv3gVJE68FKunc= =rBE0 -----END PGP SIGNATURE----- --------------enig2D2E61241FA467620DB14AAB--