From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TOv5Z-0005Eo-H2
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 14:45:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TOv5Y-0002xr-FJ
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 14:45:01 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:62172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TOv5Y-0002xm-8S
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 14:45:00 -0400
Received: by mail-wg0-f53.google.com with SMTP id dr1so5927179wgb.10
	for <qemu-devel@nongnu.org>; Thu, 18 Oct 2012 11:44:59 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50804E21.6080401@redhat.com>
Date: Thu, 18 Oct 2012 20:44:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350468595-5238-1-git-send-email-kraxel@redhat.com>
	<1350468595-5238-4-git-send-email-kraxel@redhat.com>
	<507FD407.5020506@redhat.com>
In-Reply-To: <507FD407.5020506@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Il 18/10/2012 12:03, Gerd Hoffmann ha scritto:
> Trying another approach, see attached patch.  This adds backend-specific
> qemu commands to add chardevs, with just the parameters needed for the
> specific backend.  Starting with file and tty, both accepting a path.
> 'file' is nice for testing, 'tty' very useful when hotplugging serial
> devices on the host.  Others can be added as needed.  We probably don't
> need all of them.  For example hotplugging the 'stdio' chardev doesn't
> make much sense.
> 
> Advantage #1: Cleaner API.
> Advantage #2: No legacy syntax headache when qomifying chardevs.

Disadvantage #1: Harder to extend, more code
Disadvantage #2: Different from all other kinds of host devices.

I still prefer the other one.

Paolo