From: Andre Przywara <andre.przywara@amd.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH] i386/cpu: name new CPUID bits
Date: Fri, 19 Oct 2012 01:34:19 +0200 [thread overview]
Message-ID: <508091FB.1030705@amd.com> (raw)
In-Reply-To: <20121018163321.GX16289@otherpad.lan.raisama.net>
On 10/18/12 18:33, Eduardo Habkost wrote:
> On Wed, Oct 17, 2012 at 11:17:26PM +0200, Andre Przywara wrote:
>> Update QEMU's knowledge of CPUID bit names. This allows to
>> enable/disable those new features on QEMU's command line when
>> using KVM and prepares future feature enablement in QEMU.
...
>> @@ -79,10 +79,10 @@ static const char *ext3_feature_name[] = {
>> "lahf_lm" /* AMD LahfSahf */, "cmp_legacy", "svm", "extapic" /* AMD ExtApicSpace */,
>> "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
>> "3dnowprefetch", "osvw", "ibs", "xop",
>> - "skinit", "wdt", NULL, NULL,
>> - "fma4", NULL, "cvt16", "nodeid_msr",
>> - NULL, NULL, NULL, NULL,
>> - NULL, NULL, NULL, NULL,
>> + "skinit", "wdt", NULL, "lwp",
>> + "fma4", "tce", NULL, "nodeid_msr",
>
> You removed cvt16, here.
On purpose, cvt16 is dead. It seems to have been advertised in the
documentation for some time, but later disappeared. The respective
instructions are now reported via the F16C flag in the Intel leaf.
If you want to know more, I can dig deeper and ask some people. But the
bit is now "reserved" and was never '1' in any silicon. (And was
introduced by me into QEMU :-(
>
> All the rest of the flags look OK to me.
Thanks.
Regards,
Andre.
next prev parent reply other threads:[~2012-10-18 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 21:17 [Qemu-devel] [PATCH] i386/cpu: name new CPUID bits Andre Przywara
2012-10-18 16:33 ` Eduardo Habkost
2012-10-18 23:34 ` Andre Przywara [this message]
2012-10-19 1:14 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508091FB.1030705@amd.com \
--to=andre.przywara@amd.com \
--cc=anthony@codemonkey.ws \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).