From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Andre.Przywara@amd.com>) id 1TOxy6-0000DN-Im
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 17:49:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Andre.Przywara@amd.com>) id 1TOxy5-0002Ot-Ll
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 17:49:30 -0400
Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181]:10174
	helo=ch1outboundpool.messaging.microsoft.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Andre.Przywara@amd.com>) id 1TOxy5-0002Oi-GP
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 17:49:29 -0400
Message-ID: <508091FB.1030705@amd.com>
Date: Fri, 19 Oct 2012 01:34:19 +0200
From: Andre Przywara <andre.przywara@amd.com>
MIME-Version: 1.0
References: <1350508646-32386-1-git-send-email-andre.przywara@amd.com>
	<20121018163321.GX16289@otherpad.lan.raisama.net>
In-Reply-To: <20121018163321.GX16289@otherpad.lan.raisama.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] i386/cpu: name new CPUID bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

On 10/18/12 18:33, Eduardo Habkost wrote:
> On Wed, Oct 17, 2012 at 11:17:26PM +0200, Andre Przywara wrote:
>> Update QEMU's knowledge of CPUID bit names. This allows to
>> enable/disable those new features on QEMU's command line when
>> using KVM and prepares future feature enablement in QEMU.
...
>> @@ -79,10 +79,10 @@ static const char *ext3_feature_name[] = {
>>       "lahf_lm" /* AMD LahfSahf */, "cmp_legacy", "svm", "extapic" /* AMD ExtApicSpace */,
>>       "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
>>       "3dnowprefetch", "osvw", "ibs", "xop",
>> -    "skinit", "wdt", NULL, NULL,
>> -    "fma4", NULL, "cvt16", "nodeid_msr",
>> -    NULL, NULL, NULL, NULL,
>> -    NULL, NULL, NULL, NULL,
>> +    "skinit", "wdt", NULL, "lwp",
>> +    "fma4", "tce", NULL, "nodeid_msr",
>
> You removed cvt16, here.

On purpose, cvt16 is dead. It seems to have been advertised in the 
documentation for some time, but later disappeared. The respective 
instructions are now reported via the F16C flag in the Intel leaf.

If you want to know more, I can dig deeper and ask some people. But the 
bit is now "reserved" and was never '1' in any silicon. (And was 
introduced by me into QEMU :-(

>
> All the rest of the flags look OK to me.

Thanks.

Regards,
Andre.