From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] usb: split packet result into actual_length + status
Date: Fri, 19 Oct 2012 11:00:05 +0200 [thread overview]
Message-ID: <50811695.7010400@redhat.com> (raw)
In-Reply-To: <1350569156-2565-2-git-send-email-hdegoede@redhat.com>
Hi,
> This patch unfortunately is somewhat invasive, since makeing the qemu
> usb core deal with this requires changes everywhere. This patch only
> prepares the usb core for this, all the hcd / device changes are done
> in such a way that there are no functional changes.
/me likes it.
When touching this _anyway_: How about making usb_handle_packet and
->handle_data callbacks return void (or bool for completed/async) and
expect drivers to fill the fields in USBPacket instead? That would kill
a little annonying difference in sync/async packet handling.
Adding a usb_packet_result(packet, length, status) helper function would
probably useful too.
cheers,
Gerd
next prev parent reply other threads:[~2012-10-19 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 14:05 [Qemu-devel] [PATCH 0/4] RFC: usb: split packet result into actual_length + status Hans de Goede
2012-10-18 14:05 ` [Qemu-devel] [PATCH 1/4] " Hans de Goede
2012-10-19 9:00 ` Gerd Hoffmann [this message]
2012-10-19 10:21 ` Hans de Goede
2012-10-31 13:01 ` Hans de Goede
2012-10-18 14:05 ` [Qemu-devel] [PATCH 2/4] usb-redir: Allow packets to have both data and an error-status Hans de Goede
2012-10-18 14:05 ` [Qemu-devel] [PATCH 3/4] ehci: Add support for packets with both data and an error status Hans de Goede
2012-10-18 14:05 ` [Qemu-devel] [PATCH 4/4] xhci: " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50811695.7010400@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).