From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TP8t2-0004li-H5
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 05:29:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TP8t1-0001vW-L0
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 05:29:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TP8t1-0001ul-Ci
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 05:28:59 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9J9SulD030569
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 19 Oct 2012 05:28:58 -0400
Message-ID: <50811695.7010400@redhat.com>
Date: Fri, 19 Oct 2012 11:00:05 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1350569156-2565-1-git-send-email-hdegoede@redhat.com>
	<1350569156-2565-2-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1350569156-2565-2-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] usb: split packet result into
	actual_length + status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

> This patch unfortunately is somewhat invasive, since makeing the qemu
> usb core deal with this requires changes everywhere. This patch only
> prepares the usb core for this, all the hcd / device changes are done
> in such a way that there are no functional changes.

/me likes it.

When touching this _anyway_:  How about making usb_handle_packet and
->handle_data callbacks return void (or bool for completed/async) and
expect drivers to fill the fields in USBPacket instead?  That would kill
a little annonying difference in sync/async packet handling.

Adding a usb_packet_result(packet, length, status) helper function would
probably useful too.

cheers,
  Gerd