From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38712)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TPCOD-0002Ud-8D
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:13:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TPCOC-0000T6-BZ
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:13:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TPCOC-0000Sq-3B
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:13:24 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9JDDMqD008165
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 19 Oct 2012 09:13:23 -0400
Message-ID: <508151F1.4000203@redhat.com>
Date: Fri, 19 Oct 2012 15:13:21 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350571770-9836-1-git-send-email-pbonzini@redhat.com>
	<1350571770-9836-11-git-send-email-pbonzini@redhat.com>
	<50814D98.8050408@redhat.com>
In-Reply-To: <50814D98.8050408@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

Il 19/10/2012 14:54, Kevin Wolf ha scritto:
>> > +    proto_drv = bdrv_find_protocol(target);
>> > +    if (!proto_drv) {
>> > +        error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
> This error message is still not fixed, and totally confusing, pointing
> at the wrong cause. No matter what changes to the error reporting we do
> later, we should add a better error string right now.

I think there's time for this before 1.3.  Either we fix everything in
this series, or since this is cut-and-paste we should not fix the pasted
occurrence.  Otherwise the fix will be harder to review and it's easier
to miss something.

Paolo