From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPCy3-0006Py-H8 for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:50:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPCxx-0003UM-5A for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:50:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPCxw-0003U7-TR for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:50:21 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9JDoJda022349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Oct 2012 09:50:20 -0400 Message-ID: <50815A99.8040404@redhat.com> Date: Fri, 19 Oct 2012 15:50:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20121018134256.5f6d745d@doriath.home> <1020421226.13368559.1350638849130.JavaMail.root@redhat.com> <20121019102321.25b3b2e7@doriath.home> In-Reply-To: <20121019102321.25b3b2e7@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Il 19/10/2012 15:23, Luiz Capitulino ha scritto: >> > >> > With HMP yes, with QMP no. You just get "An incoming migration is >> > expected before this command can be executed" and no clue that disks >> > are encrypted. > We could move the bdrv_iterate() calls before the RUN_STATE_INMIGRATE check > in qmp_cont(), but if this patch fixes all the cases you mention then let's > just apply it. I'm all for that. :) Paolo