From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPGJn-0002i1-J6 for qemu-devel@nongnu.org; Fri, 19 Oct 2012 13:25:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPGJj-0005bg-JK for qemu-devel@nongnu.org; Fri, 19 Oct 2012 13:25:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPGJj-0005ZO-BC for qemu-devel@nongnu.org; Fri, 19 Oct 2012 13:25:03 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9JHP14N013440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Oct 2012 13:25:02 -0400 Message-ID: <50818CEA.4010709@redhat.com> Date: Fri, 19 Oct 2012 19:24:58 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1350571770-9836-1-git-send-email-pbonzini@redhat.com> <1350571770-9836-13-git-send-email-pbonzini@redhat.com> In-Reply-To: <1350571770-9836-13-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 12/16] qemu-iotests: add mirroring test case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 18.10.2012 16:49, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > v2->v3: new testcases test_cancel_after_ready and > test_medium_not_found, removed obsolete workaround > for os.remove failure. Fixed copyright header. > > tests/qemu-iotests/041 | 364 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/041.out | 5 + > tests/qemu-iotests/group | 1 + > 3 file modificati, 370 inserzioni(+) > create mode 100755 tests/qemu-iotests/041 > create mode 100644 tests/qemu-iotests/041.out You added two test cases but forgot to update the reference output: --- 041.out 2012-10-19 10:01:15.244229847 -0400 +++ 041.out.bad 2012-10-19 10:01:24.841170380 -0400 @@ -1,5 +1,5 @@ -.......... +............ ---------------------------------------------------------------------- -Ran 10 tests +Ran 12 tests OK Failures: 041 Failed 1 of 1 tests Kevin