From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TPL0D-0004n0-MR
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 18:25:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TPL0C-0003WT-Rk
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 18:25:13 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:52379)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TPL0C-0003WG-L2
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 18:25:12 -0400
Received: by mail-pb0-f45.google.com with SMTP id rp2so719608pbb.4
	for <qemu-devel@nongnu.org>; Fri, 19 Oct 2012 15:25:11 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5081D344.5020509@twiddle.net>
Date: Sat, 20 Oct 2012 08:25:08 +1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1349812584-19551-1-git-send-email-aurelien@aurel32.net>
	<1349812584-19551-15-git-send-email-aurelien@aurel32.net>
	<5075AC5A.6040503@twiddle.net>
	<20121019202412.GA6109@ohm.aurel32.net>
In-Reply-To: <20121019202412.GA6109@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 2012-10-20 06:24, Aurelien Jarno wrote:
> Agreed. On the other hand, the few lines just above the one your quoted
> would be more complicated:
> 
> +                    if (!(call_flags & TCG_CALL_NO_READ_GLOBALS)) {
> +                        /* globals should be synced to memory */
> +                        memset(mem_temps, 1, s->nb_globals);
> +                    }
> 
> would have to be written:
> 
> +                    if (!(call_flags & TCG_CALL_NO_READ_WRITE_GLOBALS) ||
> +                        (call_flags & TCG_CALL_WRITE_GLOBALS)) {
> +                        /* globals should be synced to memory */
> +                        memset(mem_temps, 1, s->nb_globals);
> +                    }
> 
> Note sure it makes the things clearer, and definitely not shorter.

Ah, didn't think of that.  Oh well.


r~