From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhqk-000128-9S for qemu-devel@nongnu.org; Sat, 20 Oct 2012 18:48:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPhqj-0001Ki-9c for qemu-devel@nongnu.org; Sat, 20 Oct 2012 18:48:58 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:40372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhqj-0001JK-41 for qemu-devel@nongnu.org; Sat, 20 Oct 2012 18:48:57 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so1157379pbb.4 for ; Sat, 20 Oct 2012 15:48:55 -0700 (PDT) Sender: Richard Henderson Message-ID: <50832A54.5020609@twiddle.net> Date: Sun, 21 Oct 2012 08:48:52 +1000 From: Richard Henderson MIME-Version: 1.0 References: <1350744508-7066-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1350744508-7066-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Revert "target-sparc: Make cpu_dst local to OP=2 insns" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Blue Swirl , qemu-devel@nongnu.org On 2012-10-21 00:48, Aurelien Jarno wrote: > I am not sure it is the real problem, but at least the optimization of > using the destination register as a temporary is wrong when the > instruction might trigger an exception. In that case the result is > written to the destination register while it should have not. > > This reverts commit 5793f2a47e201d251856c7956d6f7907ec0d9f1f. Which insn might trigger an exception? Most OP=2 insns don't. There's divide, but that's done out-of-line, so the assignment to dst does not happen before the exception... Is this sparc64? I assume so, since I did test sparc32... r~