From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE
Date: Sun, 21 Oct 2012 16:24:09 +1000 [thread overview]
Message-ID: <50839509.9020806@twiddle.net> (raw)
In-Reply-To: <20121021042602.GA15193@ohm.aurel32.net>
On 2012-10-21 14:26, Aurelien Jarno wrote:
>> > - if (TCG_TARGET_REG_BITS == 64) {
>> > - /* ??? We assume all operations have left us with register
>> > - contents that are zero extended. So far this appears to
>> > - be true. If we want to enforce this, we can either do
>> > - an explicit zero-extension here, or (if GUEST_BASE == 0)
>> > - use the ADDR32 prefix. For now, do nothing. */
>> > -
> AFAIU this comment is still valid when %gs is/can not be used. Why
> removing it?
>
Merge error. I guess I should retain it.
r~
next prev parent reply other threads:[~2012-10-21 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 3:28 [Qemu-devel] [PATCH] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE Richard Henderson
2012-10-18 3:36 ` [Qemu-devel] [PATCH v2] " Richard Henderson
2012-10-21 4:26 ` Aurelien Jarno
2012-10-21 6:24 ` Richard Henderson [this message]
2012-10-21 20:43 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 2:11 Richard Henderson
2012-10-22 5:59 ` Aurelien Jarno
2012-10-22 21:19 ` Richard Henderson
2012-10-29 14:34 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50839509.9020806@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).