From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPoxM-0001tH-1M for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:24:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPoxH-0007Jm-Pi for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:24:15 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:42467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPoxH-0007Jh-JU for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:24:11 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so1262247pbb.4 for ; Sat, 20 Oct 2012 23:24:10 -0700 (PDT) Sender: Richard Henderson Message-ID: <50839509.9020806@twiddle.net> Date: Sun, 21 Oct 2012 16:24:09 +1000 From: Richard Henderson MIME-Version: 1.0 References: <1350530900-28991-1-git-send-email-rth@twiddle.net> <1350531365-29257-1-git-send-email-rth@twiddle.net> <20121021042602.GA15193@ohm.aurel32.net> In-Reply-To: <20121021042602.GA15193@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 2012-10-21 14:26, Aurelien Jarno wrote: >> > - if (TCG_TARGET_REG_BITS == 64) { >> > - /* ??? We assume all operations have left us with register >> > - contents that are zero extended. So far this appears to >> > - be true. If we want to enforce this, we can either do >> > - an explicit zero-extension here, or (if GUEST_BASE == 0) >> > - use the ADDR32 prefix. For now, do nothing. */ >> > - > AFAIU this comment is still valid when %gs is/can not be used. Why > removing it? > Merge error. I guess I should retain it. r~