From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] tcg/i386: remove suboptimal register shifting
Date: Sun, 21 Oct 2012 16:41:43 +1000 [thread overview]
Message-ID: <50839927.5040003@twiddle.net> (raw)
In-Reply-To: <1350754131-18667-1-git-send-email-aurelien@aurel32.net>
On 2012-10-21 03:28, Aurelien Jarno wrote:
> Now that CONFIG_TCG_PASS_AREG0 has been removed, it's easier to get
> an optimal code for the load/store functions.
>
> First swap the two registers used in tcg_out_tlb_load() so that the
> address end-up in the second register instead of the first one. Adjust
> tcg_out_qemu_ld() and tcg_out_qemu_st() to respectively call
> tcg_out_qemu_ld_direct() and tcg_out_qemu_st_direct() with the correct
> registers. Then replace the register shifting by direct load of the
> arguments.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2012-10-21 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 17:28 [Qemu-devel] [PATCH 1/2] tcg/i386: remove suboptimal register shifting Aurelien Jarno
2012-10-20 17:28 ` [Qemu-devel] [PATCH 2/2] tcg/i386: remove ld/st third argument register constraint Aurelien Jarno
2012-10-21 6:42 ` Richard Henderson
2012-10-21 6:41 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50839927.5040003@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).