From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPpEI-00042i-PC for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:41:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPpEH-00036l-Lj for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:41:46 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:57510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPpEH-00036h-El for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:41:45 -0400 Received: by mail-da0-f45.google.com with SMTP id n15so834788dad.4 for ; Sat, 20 Oct 2012 23:41:44 -0700 (PDT) Sender: Richard Henderson Message-ID: <50839927.5040003@twiddle.net> Date: Sun, 21 Oct 2012 16:41:43 +1000 From: Richard Henderson MIME-Version: 1.0 References: <1350754131-18667-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1350754131-18667-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] tcg/i386: remove suboptimal register shifting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 2012-10-21 03:28, Aurelien Jarno wrote: > Now that CONFIG_TCG_PASS_AREG0 has been removed, it's easier to get > an optimal code for the load/store functions. > > First swap the two registers used in tcg_out_tlb_load() so that the > address end-up in the second register instead of the first one. Adjust > tcg_out_qemu_ld() and tcg_out_qemu_st() to respectively call > tcg_out_qemu_ld_direct() and tcg_out_qemu_st_direct() with the correct > registers. Then replace the register shifting by direct load of the > arguments. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~