From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TPpEo-0004lq-P9
	for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:42:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TPpEn-00039j-P6
	for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:42:18 -0400
Received: from mail-da0-f45.google.com ([209.85.210.45]:55768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TPpEn-00039c-Ic
	for qemu-devel@nongnu.org; Sun, 21 Oct 2012 02:42:17 -0400
Received: by mail-da0-f45.google.com with SMTP id n15so834889dad.4
	for <qemu-devel@nongnu.org>; Sat, 20 Oct 2012 23:42:16 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50839947.3080809@twiddle.net>
Date: Sun, 21 Oct 2012 16:42:15 +1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1350754131-18667-1-git-send-email-aurelien@aurel32.net>
	<1350754131-18667-2-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1350754131-18667-2-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg/i386: remove ld/st third argument
 register constraint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 2012-10-21 03:28, Aurelien Jarno wrote:
> On x86_64, remove the constraint on the third argument register which
> is not needed:
>  - For loads the helper arguments are env, addr, mem_idx. The addr
>    value should not be in the two first argument registers as they are
>    used in tcg_out_tlb_load().
>  - For stores the helper arguments are env, addr, data, mem_idx.
>    The addr and data values should not be in the two first argument
>    registers as they are used in tcg_out_tlb_load(). The data value
>    should also not be in the two first argument registers, but could
>    be in the third argument register in which case it would be already
>    loaded at the right location.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~