From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQAyK-0006xp-U8 for qemu-devel@nongnu.org; Mon, 22 Oct 2012 01:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQAyK-0004J8-2j for qemu-devel@nongnu.org; Mon, 22 Oct 2012 01:54:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQAyJ-0004Iy-Qw for qemu-devel@nongnu.org; Mon, 22 Oct 2012 01:54:44 -0400 Message-ID: <5084DF9A.5000803@redhat.com> Date: Mon, 22 Oct 2012 07:54:34 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 25/26] q35: fill in usb pci slots with -usb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com Hi, > + pci_create_simple_multifunction( > + host_bus, PCI_DEVFN(ICH9_USB_DEV, ICH9_USB_EHCI1_FUNC), > + true, "ich9-usb-ehci1"); > /* XXX: EHCI */ You can remove that comment now ;) cheers, Gerd