From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQFR3-0008RN-Kv for qemu-devel@nongnu.org; Mon, 22 Oct 2012 06:40:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQFQx-0003LW-Ub for qemu-devel@nongnu.org; Mon, 22 Oct 2012 06:40:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQFQx-0003LN-Mr for qemu-devel@nongnu.org; Mon, 22 Oct 2012 06:40:35 -0400 Message-ID: <50852299.8090109@redhat.com> Date: Mon, 22 Oct 2012 12:40:25 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1350897839-29593-1-git-send-email-pingfank@linux.vnet.ibm.com> <1350897839-29593-14-git-send-email-pingfank@linux.vnet.ibm.com> In-Reply-To: <1350897839-29593-14-git-send-email-pingfank@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Stefan Hajnoczi , Marcelo Tosatti , qemu-devel@nongnu.org, Anthony Liguori , Jan Kiszka , Paolo Bonzini On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > The broken device state is caused by releasing local lock before acquiring > big lock. To fix this issue, we have two choice: > 1.use busy flag to protect the state > The drawback is that we will introduce independent busy flag for each > independent device's logic unit. > 2.reload the device's state > The drawback is if the call chain is too deep, the action to reload will > touch each layer. Also the reloading means to recaculate the intermediate > result based on device's regs. > > This patch adopt the solution 1 to fix the issue. Doesn't the nested mmio patch detect this? -- error compiling committee.c: too many arguments to function