From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQHd2-00027z-C8 for qemu-devel@nongnu.org; Mon, 22 Oct 2012 09:01:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQHcx-00023p-Do for qemu-devel@nongnu.org; Mon, 22 Oct 2012 09:01:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQHcx-00023k-5C for qemu-devel@nongnu.org; Mon, 22 Oct 2012 09:01:07 -0400 Message-ID: <50854369.6070106@redhat.com> Date: Mon, 22 Oct 2012 15:00:25 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1349800368-15228-1-git-send-email-avi@redhat.com> <1349800368-15228-15-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, liu ping fan , Blue Swirl , Anthony Liguori , Paolo Bonzini On 10/22/2012 02:57 PM, Peter Maydell wrote: > On 9 October 2012 17:32, Avi Kivity wrote: >> Instead of calling a global function on coalesced mmio changes, which >> routes the call to kvm if enabled, add coalesced mmio hooks to >> MemoryListener and make kvm use that instead. >=20 >> -int kvm_coalesce_mmio_region(target_phys_addr_t start, ram_addr_t siz= e) >> +static void kvm_coalesce_mmio_region(MemoryListener *listener, >> + MemoryRegionSection *secion, >> + target_phys_addr_t start, ram_ad= dr_t size) >> { >=20 >> + void (*coalesced_mmio_add)(MemoryListener *listener, MemoryRegion= Section *section, >> + target_phys_addr_t addr, target_phys_a= ddr_t len); >=20 > These disagree about the type of the 'size/len' parameter, which means > this doesn't compile on 32-bit systems where target_phys_addr_t is 64 > bits but ram_addr_t is 32 bits: >=20 > /home/petmay01/git/qemu/kvm-all.c:818:5: error: initialization from > incompatible pointer type [-Werror] > /home/petmay01/git/qemu/kvm-all.c:818:5: error: (near initialization > for =E2=80=98kvm_memory_listener.coalesced_mmio_add=E2=80=99) [-Werror] > /home/petmay01/git/qemu/kvm-all.c:819:5: error: initialization from > incompatible pointer type [-Werror] > /home/petmay01/git/qemu/kvm-all.c:819:5: error: (near initialization > for =E2=80=98kvm_memory_listener.coalesced_mmio_del=E2=80=99) [-Werror] Thanks, fixed and re-pushed. New HEAD is 1c380f9460522f. --=20 error compiling committee.c: too many arguments to function