From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TQI1h-0004LR-DU
	for qemu-devel@nongnu.org; Mon, 22 Oct 2012 09:26:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TQI1c-0003wp-Na
	for qemu-devel@nongnu.org; Mon, 22 Oct 2012 09:26:41 -0400
Received: from cantor2.suse.de ([195.135.220.15]:40438 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TQI1c-0003wl-HH
	for qemu-devel@nongnu.org; Mon, 22 Oct 2012 09:26:36 -0400
Message-ID: <50854980.2010908@suse.de>
Date: Mon, 22 Oct 2012 15:26:24 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1350677360.git.jbaron@redhat.com>
	<707fd29bf6b842cb43ceec3fd81351a24309fb23.1350677362.git.jbaron@redhat.com>
In-Reply-To: <707fd29bf6b842cb43ceec3fd81351a24309fb23.1350677362.git.jbaron@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Baron <jbaron@redhat.com>
Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, armbru@redhat.com, kraxel@redhat.com

Am 19.10.2012 22:43, schrieb Jason Baron:
> From: Jason Baron <jbaron@redhat.com>
>=20
> This adds support for the DECchip 21154 PCI bridge.
>=20
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
>  hw/Makefile.objs |    2 +-
>  hw/i21154.c      |  113 ++++++++++++++++++++++++++++++++++++++++++++++=
++++++++
>  hw/i21154.h      |    9 ++++
>  3 files changed, 123 insertions(+), 1 deletions(-)
>  create mode 100644 hw/i21154.c
>  create mode 100644 hw/i21154.h

Why is this creating a new file and not reusing dec_pci.c? We shouldn't
have two parallel implementations of the same chip.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg